----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115963/ -----------------------------------------------------------
Review request for KDE Frameworks and Matthew John Dawson. Repository: kconfig Description ------- Fix interference from kdeplatformtheme into unittests kdeplatformtheme would load kdeglobals and the app config file, in order to load settings, before the unittests get a chance to call QStandardPaths::setTestModeEnabled(true). As a result, the test would keep getting references to "wrong" shared config objects, pointing to the real user's locations rather than the test directories. This fixes e.g. kconfigdialog_unittest from kconfigwidgets for me (it only passes on build.kde.org because it doesn't install frameworkintegration for testing this framework) Diffs ----- src/core/ksharedconfig.cpp 4f0e8d698f60fd05c25e4796be12a35facb8cd38 Diff: https://git.reviewboard.kde.org/r/115963/diff/ Testing ------- kconfigdialog_unittest now passes with frameworkintegration installed. The tests in frameworkintegration still pass. Thanks, David Faure
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
