----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115936/ -----------------------------------------------------------
(Updated Feb. 22, 2014, 1:42 p.m.) Review request for KDE Frameworks and Chusslove Illich. Changes ------- Renamed the tests as suggested. Kept one test in ktranscriptcleantest as a template, with a comment that it can be replaced by the first actual clean-slate test Repository: ki18n Description ------- Separate ktranscript plugin test into its own autotest The plugin based test of KTranscript performs all tests with a single instance of KTranscriptImp because the plugin uses Q_GLOBAL_STATIC to create and access that instance. The non-plugin test creates a new instance for every test. Currently all scripting tests are runnable in both situations, but the non-plugin test allows for tests that need a "clean slate". Diffs (updated) ----- autotests/CMakeLists.txt eb73d21 autotests/ktranscriptcleantest.h PRE-CREATION autotests/ktranscriptcleantest.cpp PRE-CREATION autotests/ktranscripttest.h 53f3ce0 autotests/ktranscripttest.cpp 78aecb4 src/ktranscript.cpp c922e91 src/ktranscript_p.h f1cc132 Diff: https://git.reviewboard.kde.org/r/115936/diff/ Testing ------- All three tests run without failure Thanks, Kevin Krammer
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel