----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review50466 -----------------------------------------------------------
src/lib/kaboutdata.h <https://git.reviewboard.kde.org/r/115207/#comment35500> "chosen" I would actually rephrase this as "In addition to changing the result of applicationData(), this initializes the relevant properties of QCoreApplication (and its subclasses) with information from @p aboutData." src/lib/kaboutdata.cpp <https://git.reviewboard.kde.org/r/115207/#comment35499> No point changing this - Alex Merry On Feb. 21, 2014, 12:26 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115207/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 12:26 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > Let the KAboutData set information to QApplication. This way we don't have to > duplicate information by passing it to the KAboutData _and_ the QApplication. > > > Diffs > ----- > > src/lib/kaboutdata.h 2222c9e > src/lib/kaboutdata.cpp c347521 > > Diff: https://git.reviewboard.kde.org/r/115207/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
