----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115028/#review50343 -----------------------------------------------------------
src/lib/CMakeLists.txt <https://git.reviewboard.kde.org/r/115028/#comment35418> Not sure about that... I don't think we want the library itself to use deprecated methods. So knowing about that through warnings would make sense. - Kevin Ottens On Feb. 6, 2014, 5:20 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115028/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 5:20 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > Inline deprecated KUser::fullName() method > > > Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED > > KCOREADDONS_NO_DEPRECATED is the macro controlled by > generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs. > > Disable deprecation macro when building the library itself > > This prevents spurious compiler warnings (particularly when slots are > deprecated). > > > Diffs > ----- > > src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f > src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 > src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d > src/lib/CMakeLists.txt e48904dabe7b2790599c34673832b6ce38eab0e3 > > Diff: https://git.reviewboard.kde.org/r/115028/diff/ > > > Testing > ------- > > configures, compiles, tests pass (well, except KDirWatch-FAM, which has never > passed for me). > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
