----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115872/#review50274 -----------------------------------------------------------
This review has been submitted with commit c8f996b5343c017232f0b1ed6c64d3fd5d0e7658 by Alex Richardson to branch master. - Commit Hook On Feb. 18, 2014, 7:52 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115872/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 7:52 p.m.) > > > Review request for KDE Frameworks and Chusslove Illich. > > > Repository: ki18n > > > Description > ------- > > Fix <filename> KUIT markup on windows > > It breaks when there are nested tags within <filename>...</filename> since > QDir::toNativeSeparators simply replaces / with \ and then any nested XML > tags have an invalid closing tag. It also breaks with tags such as <br/> > in the file name for the same reason. > > > Diffs > ----- > > autotests/klocalizedstringtest.cpp f849ec37ac1e3968a507aa252727076a5d054d0f > src/kuitmarkup.cpp 97a8b21bd1400f3e2b06c65aa43a7fb8056c4515 > > Diff: https://git.reviewboard.kde.org/r/115872/diff/ > > > Testing > ------- > > KLocalizedStringTest passes on Windows. All changes inside #ifdef Q_OS_WIN, > so no change for Linux > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
