----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115756/#review50248 -----------------------------------------------------------
Ship it! Although a better fix would be to use QCommandLineParser; that means that --help can be used as well. - Alex Merry On Feb. 15, 2014, 12:17 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115756/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2014, 12:17 p.m.) > > > Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. > > > Repository: khtml > > > Description > ------- > > Fix argument processing in the tests > > Argument at index 0 is not the url passed in as argument. It's at > index 1. > > > Diffs > ----- > > tests/testkhtml.cpp 754b107b1c6febc61ef16bc566ab474ea60e937b > tests/testkhtmlnew.cpp e6fc9ea1fdc4cf4a5754d87a3a2f92d420b8409a > > Diff: https://git.reviewboard.kde.org/r/115756/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
