----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115713/#review49817 -----------------------------------------------------------
This review has been submitted with commit f76af8d1305d9907953463fd6df7a536d9aa4671 by Martin Gräßlin to branch master. - Commit Hook On Feb. 13, 2014, 6:53 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115713/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 6:53 a.m.) > > > Review request for KDE Frameworks, kdewin and Marco Martin. > > > Repository: knotifications > > > Description > ------- > > Remove #if HAVE_X11 blocks from kstatusnotifieritem > > They are all only around kwindowsystem framework usage which is not > needed to have in ifdefs. The runtime usage might differ, but from > looking at each line of code it works correctly. It's mostly about > virtual desktops and thus calls are simply ignored on systems not > supporting virtual desktops. > > > Diffs > ----- > > src/kstatusnotifieritem.cpp 82c4e65e1869fe00432634bcabbf410d44e4a80a > > Diff: https://git.reviewboard.kde.org/r/115713/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
