kossebau added inline comments. INLINE COMMENTS
> kconfigloader.cpp:87 > + > + if (reader.isEndDocument()) > + return false; This logic is inverted., no? We should be at token document end when reader.atEnd() turns true. In any case on successful parse this condition is met here and false returned. No caller seems to check the return value of ConfigLoaderHandler::parse(), thus nobody noticed? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26890 To: mlaurent, dfaure, apol Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
