bruns added inline comments.
INLINE COMMENTS
> thumbnail.cpp:143
>
> +bool createThumbnail(ThumbCreator *creator, const QString &path, int width,
> int height, QImage &img, qreal devicePixelRatio = 1.0)
> +{
Has to be static or in an anonymous namespace.
> thumbnail.cpp:149
> + } else {
> + return creator->create(path, width, height, img);
> + }
`width * dpr, height * dpr` gives the wanted result even without explicit
support for DPR for the majority of the thumbnailer.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D29526
To: meven, #frameworks, dfaure, broulik, sitter, ngraham, bruns
Cc: bruns, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik,
pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde,
Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham,
andrebarros, emmanuelp, rdieter, mikesomov
