marcingu added inline comments. INLINE COMMENTS
> dfaure wrote in thumbnail.cpp:776 > -1 isn't exactly a great value for an unsigned int :-) > > Or rather, it's not great enough (in the "greater than" sense) :-) > > But yeah, 0xFFFFFFFF is a good "not set yet" value for a dev_t, to be safe > against the possibility of 0. "-1 isn't exactly a great value for an unsigned int :-)" I believe "-1" guaranties unsigned to be set to its maximum value, due to how type conversion works, but I could be wrong. Do you know if size of dev_st is fixed or depends on architecture? I'd like to define const rather than use literals for checks, but I don't know if I can simply define it as 0xFFFFFFFF or if it's more complicated. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
