On Wed, Jul 15, 2020 at 12:39 AM David Faure <fa...@kde.org> wrote: > > On mardi 14 juillet 2020 19:35:41 CEST Albert Astals Cid wrote: > > El dimarts, 14 de juliol de 2020, a les 15:14:38 CEST, Jonathan Riddell va > escriure: > > > We're playing with translations in neon packages and looking at > > > kcoreaddons > > > the tars have > > > xml_mimetypes5 > > > But we can't see anything in the code which uses this. Do these > > > translations get used? > > > > Yes, the translations are used. > > > > No, they don't need to be on the tarball. > > > > The translations are used at scripty time to to fill > > https://invent.kde.org/frameworks/kcoreaddons/-/blob/master/src/mimetypes/k > > de5.xml > > > > Luigi recently did a change so the files ending in _xml_mimetypes.po don't > > get added to the release service tarballs. > > > > This didn't work here because a) KF5 is using a different branch of > > release-tools b) the file doesn't follow the same naming pattern than the > > rest of xml mimetype files we have. > > > > If DavidF is fine adapting his scripts to not release files ending in > > _xml_mimetypes.po (i.e. him or someone else patches the scripts) i > > volunteer to do the small patch for src/mimetypes/XmlMessages.sh to rename > > it. > > Fine with me, but don't we have more cases of the same kind, with different > names? Any case of translations being "integrated" into some file leads to > this. Desktop files, mimetype XML, is there really nothing else?
It's a bit more "fluid" than one would hope. Looking at update_translations the following patterns exist: - created by XmlMessages.sh unfortunately arbitrary named files but largely using the standard suffix Albert mentioned (the only other violation I can find with lxr is kpat) - created by StaticMessages.sh also arbitrary, only used for websites I think (?) - ._desktop_.po automatic - shouldn't be shipped - ._json_.po automatic - shouldn't be shipped - .appdata.po automatic - shouldn't be shipped - .metadata.po automatic - shouldn't be shipped (of course also Messages.sh with arbitrary naming, but that's the regular translations so they need shipping ^^) HS
