aacid added a comment.
In D26342#675164 <https://phabricator.kde.org/D26342#675164>, @sdepiets wrote: > In D26342#675142 <https://phabricator.kde.org/D26342#675142>, @dfaure wrote: > > > This actually breaks language auto-detection for me in the KMail composer. > > > > Testcase: > > > > - New Mail > > - I type "Bonjour," in the body > > > > Before: It's detected as French and not underlined as a typo > > > > After: The language remains English, and the word is underlined as a typo > > > > Workaround: Tools / Spelling / change language from English to French > > > > Too bad I'm realizing this is the reason for the regression only today (day of 5.71 release) by looking at the KF-5.71 changelog :( > > > I don't think that's a regression, in the previous behavior you could try to set any language to proofread, it would always auto-detect "Bonjour" as French, thus the "Tools / Spelling / change language" had not effect if autodetect was enabled at system level (while autodetection should be an application or even case by case decision). > > It may not seem like an issue for simple cases, but actually for mixed contents (i.e. an email that is 50% French, 50% English) that would be detected as English, you would have no way at all to check the French text without disabling system-wide autodectection. > > Calling setAutoDetectLanguageDisabled(false) restores the previous behavior The problem here is that David probably never set any language on purpose. you could argue that this is a deficiency of the UI, should have a checkbox for "enable spellchecking" and another for "enable spellchecking *exactly* in this language" And this is were we failed, we changed the default behaviour and that's probably not the greatest of the ideas in retrospect. Even if we could not see why anyone would set a language and would still want the auto language detection to be enabled, well it seems that at least David wanted because it's been the behaviour for ages :D Not sure what's the correct path forward though :/ REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks, cullmann, mlaurent, mludwig, aacid Cc: dfaure, aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
