sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed.
This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too much nested event looping and will be entirely unresponsive to mouse inputs when certain timers happen to trigger. A trivial way to reproduce this is to try and duplicate a file in file:/ Also making folders is actually not even implemented as the relevant mkdirjob seems to lack privilege enablement. That's not strictly speaking blocking but renders the actual UX broken. I've started a page for more comprehensive testing of the entire polkit epic. https://invent.kde.org/frameworks/kio/-/wikis/PrivilegedOperations I understand this diff is the last piece missing to enable the entire priviledge operations systems, so the entire shebang better be working first (: REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr, sitter Cc: sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns
