meven added a comment.
The patch currently does not work. INLINE COMMENTS > ervin wrote in device.h:99 > Why not have a default implementation which returns descriptions()? This > would make for a less intrusive patch (I think it's in part what @bruns > suggested earlier). Well I have to make this virtual it seems so this call is dynamically dispatched by `return_SOLID_CALL(Ifaces::Device *, d->backendObject(), QString(), displayName());` I assumed this would work based on my review comments rather than on tests :/ REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter, dfaure, ngraham Cc: ngraham, dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
