meven marked an inline comment as done. meven added a comment.
In D29397#673758 <https://phabricator.kde.org/D29397#673758>, @ngraham wrote: > Overall seems sane. Two questions though: > Is this @2x suffix standardized? No but it is already being used for icon caching. > What happens if I'm using 125% scaling, generate some previews, and then switch back to 100% (no scaling?) When your screen is scaled 125%, the application gets a dpr of 2. When you go back to 100%. the thumbnails in `~/.cache/thumbnails/large` and `~/.cache/thumbnails/normal` will be used again. Meaning you will have two sets of previews. > The images using a pixel ratio are stored in cache in ~/.cache/thumbnails/normal@2x for 256*256 (i.e 128*128@2x) and ~/.cache/thumbnails/large@2x for 512*512 (i.e 256*256@2x) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397 To: meven, dfaure, broulik, #frameworks, ngraham Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
