nicolasfella requested changes to this revision. nicolasfella added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > notifybyandroid.cpp:110 > n.setField("urgency", (jint)(notification->urgency() == > KNotification::DefaultUrgency ? KNotification::HighUrgency : > notification->urgency())); > + n.setField("visibility", > QAndroidJniObject::fromString(notification->hints().value(QLatin1String("visibility")).toString().toLower()).object<jstring>()); > The hint name should be something like x-kde-visibility REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns