xuetianweng added a comment.
In D29789#672335 <https://phabricator.kde.org/D29789#672335>, @dhaumann wrote: > I like this patch. In fact, I observed over the past years again and again that sometimes, especially if chinese or similar letters are included, the baseline is wrong in Kate, leading to much more overpainting that needed. > If this patch fixes this, then I'm all for it. Or let's put it like this: The current implementation is wrong, this patch looks less wrong than the current state :-) > > +1 Actually if this patch is accepted, we may then want to add a configurable multiplier on line height instead of enable variable lineheight support to resolve the character clip issue. Background painting to fill the gap to cover extra gap between line is probably easier and safer to implement. Equal line height would look better anyway. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29789 To: xuetianweng, rjvbb, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
