kossebau added inline comments.
INLINE COMMENTS
> kcolorcombo.cpp:222
> + namedColors.reserve(colors.size());
> + for (auto color : colors) {
> + namedColors.append({QString(), color});
`auto& ` as we just want a reference, avoids a copy constructor call each time.
> kcolorcombo.cpp:253
> + list.reserve(d->colorList.size());
> + for (auto color : d->colorList) {
> + list.append({color.second});
`auto& ` as we just want a reference, avoids a copy constructor call each time.
> kcolorcombo.cpp:264
> + ColorList list;
> + for (int index = 0; index < STANDARD_PALETTE_SIZE; ++index) {
> + list += {QString(), standardColor(index)};
list.reserve(STANDARD_PALETTE_SIZE);
REPOSITORY
R236 KWidgetsAddons
BRANCH
named_color_support
REVISION DETAIL
https://phabricator.kde.org/D29502
To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham, #vdg
Cc: kossebau, cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n,
michaelh, ngraham, bruns
