vkrause added a comment.
In D27989#670416 <https://phabricator.kde.org/D27989#670416>, @kossebau wrote: > > minimumSize() becomes deprecated by this, the deprecation macros will > > follow once the current users have been adjusted. > > IMHO you should add the macros from the start, otherwise it will be only forgotten later, as there is no mechanism to remind you. And without compiler warnings all the remaining users might never learn about it. > > I would expect you have prepared patches for some known users already to testdrive the new API for usefulness, so the set of remaining users (in KDE spheres) should be already small. And those not yet withzout a patch, what would be the plan to care for them? In the end it needs to compiler warnings to get other people in the game. After all API is not deprecated without a reason. Being too gentle with warnings does not help anyone in the end. There's two remaining users in everything covered by lxr, the Plasma clipboard (patch in review: https://phabricator.kde.org/D29478) and KDE PIM (which now depends on a sufficiently new KF5 version to actually do the migration). Both ways can be argued of course, I optimized for "helps me" (the warnings for things I can't change yet don't), and "migration is my problem" rather than "migration is somebody else's problem" (which is my understanding of how we are supposed to be doing KF deprecations to ease the 6 transition). REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27989 To: vkrause, svuorela Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
