meven added inline comments.

INLINE COMMENTS

> kpluginselector.cpp:855
> +            }
> +            KCModuleProxy *currentModuleProxy = new 
> KCModuleProxy(moduleInfo, moduleProxyParentWidget, arguments);
>              if (currentModuleProxy->realModule()) {

Adding a fileName field to KCModuleProxy would make more sense to me, and do it 
by default.
Plus KCModuleProxy has already access to the fileName since it receives 
moduleInfo. 
But I am not a specialist.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik, mart
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

Reply via email to