araujoluis marked 14 inline comments as done.
araujoluis added inline comments.
INLINE COMMENTS
> patrickelectric wrote in kcolorcombo.h:52
> This is just a suggestion and not something that's necessary to do, but maybe
> it could help to create a simple class to replace QPair:
>
> class KComboColor {
> Q_PROPERTY(QColor color MEMBER color)
> Q_PROPERTY(QString name MEMBER name)
> public:
> QColor color;
> QString name;
> }
Good suggestion, I will be thinking how to do it as this would alter the use of
lists within the code.
> cfeck wrote in kcolorcombo.h:61
> The comment still says "struct". Maybe clarify that this list is actually
> used as a map.
>
> (I guess since mapping would happen in both directions, using a QMap isn't
> useful?)
Done!
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D29502
To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,
bruns
