svuorela accepted this revision.
svuorela added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> dialog.cpp:317
> const QStringList dirs =
> QStandardPaths::locateAll(QStandardPaths::DataLocation,
> QStringLiteral("ksettingsdialog"), QStandardPaths::LocateDirectory);
> + QMap<QString /*fileName*/, QString /*fullPath*/> fileMap;
> for (const QString &dir : dirs) {
I think I read once that whenever you used a ordered map over an unordered map,
you need to justify it by talking to your manager about it. But that's also a
bit from the bucket of nitpickery unless we are in a hot codepath.
> dialog.cpp:326
> }
> + for (auto it = fileMap.constBegin(); it != fileMap.constEnd(); ++it) {
> + parseGroupFile(it.value());
nitpickery. but range based for and qAsConst on container?
REPOSITORY
R295 KCMUtils
BRANCH
fix_duplicates
REVISION DETAIL
https://phabricator.kde.org/D28760
To: dfaure, apol, broulik, davidedmundson, kossebau, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
