kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision.
REVISION SUMMARY To also support EXCLUDE_DEPRECATED_BEFORE_AND_AT=5.69.0 properly some more if-elif would have been needed, making the code more hard to read. Based on dicussion on #kde-devel with dfaure that has been left out, for some future non-version-based *_BUILD_DEPRECATED. So the focus already is on building without any own deprecated API, no-one is expected to use EXCLUDE_DEPRECATED_BEFORE_AND_AT with a certain version != CURREENT or 0. TEST PLAN Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0 (default) or CURRENT, all unit tests pass. REPOSITORY R309 KService BRANCH buildwithoutdeprecated REVISION DETAIL https://phabricator.kde.org/D29572 AFFECTED FILES autotests/kplugininfotest.cpp autotests/kservicetest.cpp autotests/kservicetest.h src/services/kmimetypetrader.cpp src/services/kservicefactory.cpp src/services/kserviceoffer.cpp src/services/kserviceoffer.h src/services/kservicetypeprofile.cpp src/services/kservicetypeprofile.h src/services/kservicetypetrader.cpp src/sycoca/kbuildservicefactory.cpp src/sycoca/kmimeassociations.cpp To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
