bport updated this revision to Diff 82028.
bport added a comment.
- Fix comments
- Ensure we don't have problem if we set value to "defaultcpp" and a global
setting override it
Regarding other comments:
- I guess you mean if (mDefault == mReference) { with if (value ==
"defaultcpp")
in that case mDefault is equal to either default from cpp value or default
from global file.
- Your first assertion is right.
Still need to fix documentation
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28221?vs=80624&id=82028
REVISION DETAIL
https://phabricator.kde.org/D28221
AFFECTED FILES
autotests/kconfigskeletontest.cpp
autotests/kconfigskeletontest.h
autotests/kconfigtest.cpp
autotests/kconfigtest.h
src/core/kconfigdata.cpp
src/core/kcoreconfigskeleton.cpp
src/core/kcoreconfigskeleton.h
src/gui/kwindowconfig.cpp
To: bport, ervin, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
