weisi added a comment.
I agree with the general idea in D29223 <https://phabricator.kde.org/D29223> and feel D29223 <https://phabricator.kde.org/D29223> is in a better shape than this diff. However, I think some festivals referred to in this diff (not mentioned in the law - 紀念日及節日實施辦法 <https://law.moj.gov.tw/LawClass/LawAll.aspx?pcode=D0020033> - but are still special days of interest that many people celebrate) can be adapted into D29223 <https://phabricator.kde.org/D29223>. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29373 To: weisi, winterz, cgiboudeaux Cc: nhiga, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
