kmaterka created this revision. kmaterka added reviewers: Plasma, Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kmaterka requested review of this revision.
REVISION SUMMARY When SvgSource is changed, old one is deleted. Connections are not automatically disconected. This change disconnects connections. TEST PLAN STEPS TO REPRODUCE 1. click on mute button for a device 2. click on the desktop to collapse the applet OBSERVED RESULT crash in step 1 and in the rare case it doesn't crash it crash in step 2 EXPECTED RESULT don't crash BUG: 420801 REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D29314 AFFECTED FILES src/declarativeimports/core/iconitem.cpp To: kmaterka, #plasma, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
