ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, cfeck, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision.
REVISION SUMMARY This partially reverts 0004e5c89a248a508a <https://phabricator.kde.org/R236:0004e5c89a248a508afcf59e7b4273c80eccf1fd>; the NoFixedCheckBox flag is redundant as just hiding the "show monospaced fonts only" checkbox when the FixedFontsOnly flag is set is enough to handle the Konsole use case (which was the primary reason that flag was introduced in the first place). Since KF 5.70 isn't released yet, that flag can be safely removed; no need to clutter the code with redundant flags, and more flags can be added in the future if there's an actual need/use-case for them. Thanks to Kurt Hindenburg for catching this, https://invent.kde.org/kde/konsole/-/merge_requests/84 TEST PLAN make && ctest REPOSITORY R236 KWidgetsAddons BRANCH l-remove-redundant-displayflag (branched from master) REVISION DETAIL https://phabricator.kde.org/D29219 AFFECTED FILES src/kfontchooser.cpp src/kfontchooser.h tests/kfontchooserdialogtest.cpp To: ahmadsamir, #frameworks, dfaure, cfeck, bport Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
