ahmadsamir marked 4 inline comments as done. ahmadsamir added a comment.
In D29138#656140 <https://phabricator.kde.org/D29138#656140>, @meven wrote: > In D29138#656094 <https://phabricator.kde.org/D29138#656094>, @dfaure wrote: > > > Wow those iterations over map.keys() were awful. > > > We still have a few of those in solid : I know. "foreach" marks the place :) INLINE COMMENTS > bruns wrote in fakecdrom.cpp:48 > The obviously better solution is to iterate over `supported_medialist` and > swap the key and value of the map. Good point. REPOSITORY R245 Solid BRANCH l-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D29138 To: ahmadsamir, #frameworks, dfaure, apol, meven Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham
