sitter added inline comments.

INLINE COMMENTS

> dfaure wrote in CMakeLists.txt:60
> Isn't that what I did here? Now all of kio-extras gets that flag.
> 
> And BTW everything built by kdesrc-build actually builds with this flag 
> (since I have it in my kdesrc-buildrc). But that doesn't allow setting it in 
> ECM, there is more code using ECM out there...

Huh, I must have scrolled right past it. All is perfect!

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29149

To: dfaure, thiago, sitter
Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, rdieter, mikesomov

Reply via email to