leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed.
On a related note, i'm waiting on reviews on D28701 <https://phabricator.kde.org/D28701> at the moment... which i'm afraid might wreck some havoc with your patch, as they touch some of the same bits of the codebase. INLINE COMMENTS > installation.cpp:632 > + Question question(Question::ContinueCancelQuestion); > + question.setQuestion(err); > + Question::Response response = question.ask(); This will want to be more... question like... "The thing failed" isn't really a question, not sure how the user's supposed to make an informed choice based on that... Perhaps something like "The uninstallation process failed to run the command %1. The output was:\n%2\nIf you think this is incorrect, you can continue, or you can cancel the process." (given how much this is an error situation, it feels like we can give the user a bit of technical information... cancelling in a panic would be the appropriate reaction to "I don't know" anyway for this sort of thing, so thinking we'd be ok with doing that). REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
