hallas marked an inline comment as done. hallas added inline comments. INLINE COMMENTS
> bruns wrote in fstabhandling.cpp:374 > The `id()` method and members are still part of the FstabEntry, where they do > not belong. > > The UDIs go through some further mangling in `FstabHandling::deviceList()`, > which should be covered by the unit-tests as well. > > Conceptually, the > `_k_deviceNameForMountpoint`/`_k_deviceNameForFilesystemEntry` should be part > of the m_mtabCache/m_fstabCache class (which currently is just a > `QMultiHash<>`). This class can then be unit tested easily. > > For now, keep the `_k_deviceNameForMountpoint` inside fstabhandling.cpp @bruns - I am little confused now. You wrote previously that you could see the point in the `id()` function, but now you want it moved? What kind of unit test are you missing? I can't quite follow the added mangling in `FstabHandling::deviceList()`? I don't think we have (or ever have) had any unit test of FstabHandling, but that was one of the things I am trying to achieve was this patch series that breaks up and decouples the code pieces into smaller bits. Could I ask you to take a look at it again? Sorry for nagging, I just really want to close this up soon and move on with the next patches ;D REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27152 To: hallas, #frameworks, bruns, meven Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
