bruns added a comment.
In D28682#644430 <https://phabricator.kde.org/D28682#644430>, @astippich wrote: > In D28682#644414 <https://phabricator.kde.org/D28682#644414>, @bruns wrote: > > > In general fine for me. > > > > How will Elisa deal with the indexer maybe crashing inbetween? Do we also need a signal for a batch start? > > > From my (limited) understanding, the finishedIndexingFile will no be emitted when an indexers crashes, does it? Then I think it is fine without an additional signal as long as the done() signal is still emitted as it is possible to reset the applications' internal list. Or will it retry some files of the current batch? It will not be emitted for the file it crashed on, but for the earlier files. So you may have the following for the files 'a, b, c, d': - S:a, F:a - S:b, F:b - S:c <crash> - S:a, F:a - S:b, F:b - done - S:c, <crash> - S:d, F:d - done So when you only listen to `finished` and `done`, you should keep the files in a `set`, but after the `done` the earlier files should be committed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
