meven requested changes to this revision.
meven added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> copyjob.cpp:814
> Q_Q(CopyJob);
> - if (m_currentStatSrc != m_srcList.constEnd()) {
> + while (m_currentStatSrc != m_srcList.constEnd()) {
> m_currentSrcURL = (*m_currentStatSrc);
about @anthonyfieroni comment
Add `&& !isKilled()` with a code path to handle it properly.
> copyjob.cpp:892
> if (that) {
> statNextSrc(); // we could use a loop instead of a
> recursive call :)
> }
I guess we can update this comment
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28669
To: McPain, #frameworks, dfaure, meven, ahmadsamir
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,
ngraham, bruns
