trmdi abandoned this revision. trmdi added a comment.
In D27951#641173 <https://phabricator.kde.org/D27951#641173>, @meven wrote: > In D27951#639386 <https://phabricator.kde.org/D27951#639386>, @trmdi wrote: > > > In D27951#639350 <https://phabricator.kde.org/D27951#639350>, @meven wrote: > > > > > Anything that concerns a kdeconnet:/ url is handled by the kdeconnect ioslave, including the stat call made in `KIO::StatJob`. > > > It is in the kdeconnect code base, the issue you point to is there. > > > > > > Thanks, got it. Then could we simply use KMountPoint instead of UDS_Device_ID ? KMountPoint seems more reliable. > > > But KMountPoint induces more cost (it makes a syscall and a bunch of parsing). > So instead I would recommend fixing the issue in kdeconnect (and potentially other ioslave) as it will fix things here and elsewhere potentially too. > > Also `local = url.isLocalFile` should return false for kdeconnect in the first place. > So I belive you can avoid using KMountPoint at all and use only stat. No, kde connect files has local urls. Fixing every ioslave is too difficult. So I should drop this idea. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson Cc: bruns, elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham
