bruns added inline comments.

INLINE COMMENTS

> jobtest.cpp:1510
> +{
> +    // this test doesn't make sense on the CI as it's an LXC container with 
> one partition
> +    if (!otherTmpDirIsOnSamePartition()) {

This should only apply to the `QVERIFY(device != otherDevice);`

> bruns wrote in jobtest.cpp:1524
> Its 'statDetails**With**Inode' not 'statDetailsInode**Only**'

i.e. the test should be renamed now.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Reply via email to