apol added a comment.

  Code per se looks okay, not that I've ever used a rust workspace.
  
  It does need documentation though. See other ECM modules to see what it looks 
like.
  
  I wonder if this is covering a very widespread use-case. If there's just one 
application that needs it, it could make sense to keep it there and once it's 
polished, we put it in ECM to share.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28444

To: cblack, #frameworks, #build_system
Cc: apol, IlyaBizyaev, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, GB_2, bencreasy, michaelh, ngraham, bruns

Reply via email to