kossebau added inline comments.

INLINE COMMENTS

> knotificationjobuidelegate.h:58
> +    class Private;
> +    Private *const d;
> +};

Using QScopedPointer or std::unique_ptr instead of raw pointer also avoids need 
to manually delete in destructor, also better practice these days.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28295

To: broulik, #frameworks, nicolasfella, dfaure
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

Reply via email to