pino added inline comments. INLINE COMMENTS
> bruns wrote in kinotify.cpp:350 > asserts are IMHO pointless, nobody enables them, but it clutters the code. > Anyone touching the code should and has to read the man pages etc anyway. no, an assert is sort of "program by contract": you make it clear that this situation ought to not happen, and it if does, at least some people may notice that > Anyone touching the code should and has to read the man pages etc anyway. and an explicit mention/comment in the code never killed anyone, nor made the code "cluttered"; also what is valid today might change in the future, so writing down why a check/assert was added make sure that people reading the changed documentation know why it made sense when it was added REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28324 To: bruns, #baloo, ngraham Cc: pino, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
