trmdi added inline comments. INLINE COMMENTS
> davidedmundson wrote in dropjob.cpp:286 > Why QStorageInfo? We're in kio. There's a KMountPoint which is similar > > I suspect this is a recursive list up the tree resolving symlinks. This will > mean blocking stat calls, so this somewhat undermines a lot of the recent > work in that field. > I suspect this is a recursive list up the tree resolving symlinks. This will > mean blocking stat calls, so this somewhat undermines a lot of the recent > work in that field. I don't understand this. Could you please explain a bit more? > davidedmundson wrote in dropjob.cpp:287 > If destination is a symlink on the same partition but that symlink points to > another partition what happens? > > I haven't checked myself, but if we are doing this I need us to be super > super sure. They are considered as different partitions, I checked. > davidedmundson wrote in dropjob.cpp:309 > This will trigger when both storage devices are invalid, which isn't what we > want. I don't understand this. How could devices be invalid if we are dropping valid urls to a valid destUrl? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
