dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
Oops I forgot to review this again after your last changes. Looks fine to me now, but meanwhile it needs s/5.67/5.69/ everywhere (docu and deprecation macros). Feel free to land if you check that there's no 67 anywhere in the diff. REPOSITORY R294 KBookmarks BRANCH addd REVISION DETAIL https://phabricator.kde.org/D25660 To: nicolasfella, #frameworks, dfaure Cc: kossebau, dfaure, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
