broulik created this revision. broulik added reviewers: Frameworks, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision.
REVISION SUMMARY So it matches what `KNotification` is doing, especially since Phonon allows playing all sorts of files, which would then end up not being played when the notification is emitted. TEST PLAN - Playback via canberra works, doesn't crash on teardown, multiple different sounds and playing the same sound repeatedly works - Playback via Phonon still works when canberra isn't found REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D28121 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/knotifyconfigactionswidget.cpp src/knotifyconfigactionswidget.h To: broulik, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
