davidedmundson added inline comments.
INLINE COMMENTS
> ExpandableListItem.qml:2
> +/*
> + * Copyright 2020 Nate Graham <n...@kde.org>
> + *
It shouldn't be in PC3. It's new API from qqc2.A
> ExpandableListItem.qml:23
> +import org.kde.plasma.core 2.0 as PlasmaCore
> +import org.kde.plasma.plasmoid 2.0
> +import org.kde.plasma.components 2.0 as PlasmaComponents
Unused?
> ExpandableListItem.qml:153
> + PlasmaComponents.Label {
> + id: listItemSubtitle
> +
Why pc2?
> ExpandableListItem.qml:179
> +
> + onClicked: collapse()
> + }
Shouldn't it run the default action?
> ExpandableListItem.qml:190
> + // TODO: or should it just be right-aligned?
> + implicitWidth: defaultActionButton.width
> + implicitHeight: defaultActionButton.height
Neve rdefine an implicit size from an actual size.
> ExpandableListItem.qml:230
> + NumberAnimation {
> + duration: units.longDuration * 3
> + easing.type: Easing.InOutCubic
Seems random
> ExpandableListItem.qml:235
> +
> + // Custom view; when defined, the actions list doesn't appear
> + Loader {
Sounds like you want 2 classes. One a subclass with the list as the custom view.
Then you don't need the container, or this switching.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D28033
To: ngraham, #vdg, #plasma
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel,
LeGast00n, GB_2, michaelh, ngraham
