leinir requested changes to this revision.
leinir added a comment.
This revision now requires changes to proceed.
Minus that little API funniness, looks pretty good from here :)
INLINE COMMENTS
> CMakeLists.txt:9
>
> -add_library(kaccounts_kio_webdav_plugin MODULE ${kio-webdav_SRCS})
> +
> +kcoreaddons_add_plugin(kaccounts_kio_webdav_plugin
wouldn't mention it, but as there's other stuff as well, looks like a stray
newline :)
> kaccountsdplugin.h:57
> public:
> - KAccountsDPlugin(QObject *parent = nullptr);
> + KAccountsDPlugin(QObject *parent, const QVariantList& args);
> virtual ~KAccountsDPlugin();
This still introduces a API break, though... Which seems especially silly given
the arguments aren't actually used. Perhaps add a new ctor, and have the one
without the arguments call the new one, but also make a qwarning (or something
similar) note that it's using an old ctor and really out to upgrade?
REPOSITORY
R155 KAccounts Integration
REVISION DETAIL
https://phabricator.kde.org/D27635
To: nicolasfella, bshah, leinir, #frameworks
