bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > fstabhandling.cpp:374 > + const FilesystemEntry fsEntry(fsname, mountpoint, type, > QStringList()); > + globalFstabCache->localData().m_mtabCache.insert(fsEntry.id(), > fsEntry); > } Why is the id() a property of the entry now? - it does not correspond to anything from the fstab/mtab - it is only used here to generate the key for the cache Please move the id generation back here, eventually changing it from `_k_deviceNameForMountpoint(const QString &source, const QString &fstype,const QString &mountpoint)` to `_k_deviceIdForFsentry(const FilesystemEntry&)` REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27152 To: hallas, #frameworks, bruns, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
