ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, sitter, broulik. Herald added a project: Frameworks. ahmadsamir requested review of this revision.
REVISION SUMMARY When setting the mime filter, check that the QMimeType we get from QMimeDatabase::mimeTypeForName() is valid before adding it to the mime filter list. This fixes a bug where if the QMimeType is invalid its name (and comment) property is empty, leading to empty entries in the filter widget drop-down menu. BUG: 417355 FIXED-IN: 5.68 TEST PLAN - Open gwenview -> file -> open and check the filter drown-down menu there are a couple (two?) empty entries - Apply diff and try again, no empty entries REPOSITORY R241 KIO BRANCH l-kfilefiltercombo (branched from master) REVISION DETAIL https://phabricator.kde.org/D27865 AFFECTED FILES src/filewidgets/kfilefiltercombo.cpp To: ahmadsamir, #frameworks, dfaure, meven, sitter, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
