svuorela requested changes to this revision.
svuorela added a comment.
This revision now requires changes to proceed.
I'm not sure I like the implementation. The current AbstractBarcode can also
be implemented, at least theoretically, by software providing other barcodes
that forever reason isn't available here. I have at least done that for some
PoC ports of other things.
I suggest instead having a
enum class BarcodeDimensions { 1d, 2d, 3d, 4d } ;
perhaps with better names, and then just a barcodeDimensions() method on
AbstractBarcode that can be switched over.
REPOSITORY
R280 Prison
REVISION DETAIL
https://phabricator.kde.org/D27730
To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
