sitter updated this revision to Diff 76865.
sitter added a comment.

  - refine code a bit
  - extend to ::get works same as smbCopyGet. in fact I feel like the two 
functions should be merged. at their hearts they both could read into 
QIODevices (QFile/QBuffer(QBA))
  - use segment class for all transfer use to ultimately replace the xfer_buf 
define with smart calculation of transfer size
  - ::smbCopyPut didn't get any measurable improvement from threading, so I am 
leaving it out for now. having written that the lack of difference may have 
been because HDD IO of the server was saturated so perhaps this deserves 
another look

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27504?vs=76001&id=76865

BRANCH
  smb-threaded-read

REVISION DETAIL
  https://phabricator.kde.org/D27504

AFFECTED FILES
  smb/CMakeLists.txt
  smb/kio_smb.h
  smb/kio_smb_dir.cpp
  smb/kio_smb_file.cpp
  smb/transfer.h

To: sitter, ngraham, cfeck
Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

Reply via email to