ahmadsamir added a comment.
I created D27615 <https://phabricator.kde.org/D27615> first; then this one on top of it (optimising the code in a separate commit). INLINE COMMENTS > apol wrote in urlhandler.cpp:55 > won't this recurse forever? I could be wrong, but this is exactly equivalent to the original code, i.e. it won't reach this unless helpcenter is empty and it's not a kde app... and I actually wanted to ask about this bit from the original code, what is it supposed to do? REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27616 To: ahmadsamir, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
