dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Nice work! Found 2 bugs though.
INLINE COMMENTS
> kio_sftp.cpp:1306
> rc = ssh_channel_poll(mSftp->channel, 1);
> - }
> -
> - if (rc < 0) {
> + } else if (rc < 0) {
> qCDebug(KIO_SFTP_LOG) << "ssh_channel_poll failed: " <<
> ssh_get_error(mSession);
Warning, you changed the logic. This "else" wasn't there, in order to catch the
case where the second call to ssh_channel_poll failed too. I think you need to
revert this "else".
> kio_sftp.cpp:2075
> if (cPath.isEmpty()) {
> - error(KIO::ERR_MALFORMED_URL, url.toDisplayString());
> - return;
> + Result::fail(KIO::ERR_MALFORMED_URL, url.toDisplayString());
> }
missing "return" in front
> kio_sftp.h:48
> + *
> + * The Result is forwared all the way to the frontend API where it is
> + * turned into an error() or finished() call.
typo: forwar*d*ed
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D27153
To: sitter, dfaure, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns,
emmanuelp, mikesomov
