> On Jan. 30, 2014, 11:47 a.m., Alex Merry wrote: > > CMakeLists.txt, lines 52-55 > > <https://git.reviewboard.kde.org/r/115269/diff/1/?file=235515#file235515line52> > > > > Make this unconditional (ie: replace all four lines by just the > > find_package line)
Will do, thanks. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115269/#review48598 ----------------------------------------------------------- On Jan. 23, 2014, 6:24 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115269/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 6:24 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdnssd-framework > > > Description > ------- > > KConfig is only required when DNSSD is found, and QtDBus is only required > when either Avahi or DNSSD is found, so don't require them unconditionally. > > > Diffs > ----- > > CMakeLists.txt defb7bbb70a6b7567e5d7d0e6b8097f57ad07a15 > src/CMakeLists.txt ef84ffa5ae5cfdfd2547c458e446cf4c9a2c7420 > > Diff: https://git.reviewboard.kde.org/r/115269/diff/ > > > Testing > ------- > > Still builds against Avahi, DNSSD, and neither backends. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
